Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return names with people API response #554

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Return names with people API response #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/api/people.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func PeopleDataHandler(
// Only query for photos and email addresses
// This may be expanded based on use case
// in the future
ReadMask("photos,emailAddresses").
ReadMask("emailAddresses,names,photos").
Sources("DIRECTORY_SOURCE_TYPE_DOMAIN_PROFILE").
Do()
if err != nil {
Expand Down Expand Up @@ -77,7 +77,7 @@ func PeopleDataHandler(
for _, email := range emails {
result, err := s.People.SearchDirectoryPeople().
Query(email).
ReadMask("photos,emailAddresses").
ReadMask("emailAddresses,names,photos").
Sources("DIRECTORY_SOURCE_TYPE_DOMAIN_PROFILE").
Do()

Expand Down
4 changes: 2 additions & 2 deletions internal/api/v2/people.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func PeopleDataHandler(srv server.Server) http.Handler {
// Only query for photos and email addresses
// This may be expanded based on use case
// in the future
ReadMask("photos,emailAddresses").
ReadMask("emailAddresses,names,photos").
Sources("DIRECTORY_SOURCE_TYPE_DOMAIN_PROFILE").
Do()
if err != nil {
Expand Down Expand Up @@ -74,7 +74,7 @@ func PeopleDataHandler(srv server.Server) http.Handler {
for _, email := range emails {
result, err := srv.GWService.People.SearchDirectoryPeople().
Query(email).
ReadMask("photos,emailAddresses").
ReadMask("emailAddresses,names,photos").
Sources("DIRECTORY_SOURCE_TYPE_DOMAIN_PROFILE").
Do()

Expand Down