Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Updates cache clearing #55

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

jeffdaley
Copy link
Contributor

Adds a clearCache function to the AlgoliaService and implements it on the dashboard. Used to override the Algolia JS module's internal cache handling and ensure up-to-date docs in the Latest Updates component.

Current behavior:
Newly In-Review docs don't appear in Latest Updates until the tab is refreshed.

New behavior:
New docs appear in Latest Updates as expected when you load the dashboard or interact with the component.

@jeffdaley jeffdaley requested a review from a team as a code owner February 15, 2023 23:24
@@ -59,27 +59,29 @@ export default class DashboardLatestUpdatesComponent extends Component<Dashboard
* Called onLoad and when tabs are changed.
*/
fetchDocs = task(async () => {
let { currentTab } = this;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed for clarity

Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jeffdaley jeffdaley merged commit 13f64dc into main Mar 7, 2023
@jeffdaley jeffdaley deleted the jeffdaley/clear-algolia-cache-on-dashboard branch March 7, 2023 02:13
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants