-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Projects navigation and tiles #514
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { helper } from "@ember/component/helper"; | ||
import { | ||
ProjectStatus, | ||
projectStatusObjects, | ||
} from "hermes/types/project-status"; | ||
|
||
export interface GetProjectStatusIconSignature { | ||
Args: { | ||
Positional: [string | undefined]; | ||
}; | ||
Return: string | undefined; | ||
} | ||
|
||
const getProjectStatusIcon = helper<GetProjectStatusIconSignature>( | ||
([status]) => { | ||
switch (status) { | ||
case ProjectStatus.Active: | ||
return projectStatusObjects[ProjectStatus.Active].icon; | ||
case ProjectStatus.Completed: | ||
return projectStatusObjects[ProjectStatus.Completed].icon; | ||
case ProjectStatus.Archived: | ||
return projectStatusObjects[ProjectStatus.Archived].icon; | ||
default: | ||
return; | ||
} | ||
}, | ||
); | ||
|
||
export default getProjectStatusIcon; | ||
|
||
declare module "@glint/environment-ember-loose/registry" { | ||
export default interface Registry { | ||
"get-project-status-icon": typeof getProjectStatusIcon; | ||
} | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
a { | ||
&:hover, | ||
&:focus { | ||
.interactive-card { | ||
@apply bg-gradient-to-t from-color-page-faint to-color-page-primary; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,41 @@ | ||
.secondary-nav { | ||
@apply flex; | ||
|
||
a { | ||
@apply relative flex h-12 w-1/3 items-center justify-center gap-1.5 rounded-none border border-color-palette-neutral-300; | ||
@apply pr-1; // optical centering | ||
@apply bg-color-page-faint; | ||
|
||
&:first-child { | ||
@apply rounded-l-button-md; | ||
} | ||
|
||
&:last-child { | ||
@apply rounded-r-button-md; | ||
} | ||
|
||
&:hover:not(.active) { | ||
@apply bg-color-page-primary; | ||
} | ||
|
||
+ a { | ||
@apply -ml-px; | ||
} | ||
|
||
&:focus { | ||
@apply z-20; | ||
} | ||
} | ||
|
||
.active { | ||
@apply underline; | ||
@apply z-10 border-color-foreground-action-hover bg-color-foreground-action text-white; | ||
|
||
path { | ||
@apply fill-current; | ||
} | ||
|
||
.status-icon-fill { | ||
fill: none; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
.product-badge { | ||
@apply absolute bg-color-palette-neutral-200 bg-gradient-to-br; | ||
@apply absolute bg-color-palette-neutral-200 bg-gradient-to-br from-transparent to-transparent; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes a visual bug when hovering the cards. |
||
|
||
&.hcp { | ||
@apply from-color-palette-neutral-500 to-color-palette-neutral-600 text-color-foreground-high-contrast; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper is also used in #414