-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProjectStatusIcon
component with color icons
#484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
Add
Add Dec 6, 2023
ProjectStatusIcon
componentProjectStatusIcon
component with color icons
jeffdaley
changed the title
Add
WIP: Add Dec 14, 2023
ProjectStatusIcon
component with color iconsProjectStatusIcon
component with color icons
jeffdaley
force-pushed
the
jeffdaley/add-project-status-icons
branch
from
December 21, 2023 01:56
00e5285
to
1a203c5
Compare
jeffdaley
commented
Dec 21, 2023
@@ -9,7 +9,11 @@ | |||
@query={{hash status=status.value}} | |||
class="hds-button hds-button--color-secondary" | |||
> | |||
<FlightIcon @name={{get-project-status-icon status.value}} class="mr-1" /> | |||
{{#if (eq status.value @status)}} | |||
<FlightIcon @name={{get-project-status-icon status.value}} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the active state we keep the monochrome icon.
jeffdaley
changed the title
WIP: Add
Add Dec 21, 2023
ProjectStatusIcon
component with color iconsProjectStatusIcon
component with color icons
jfreda
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces most monochrome project-status icons with color versions.