Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectStatusIcon component with color icons #484

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Dec 6, 2023

Replaces most monochrome project-status icons with color versions.

@jeffdaley jeffdaley changed the title Add ProjectStatusIcon component Add ProjectStatusIcon component with color icons Dec 6, 2023
@jeffdaley jeffdaley marked this pull request as ready for review December 6, 2023 21:22
@jeffdaley jeffdaley requested a review from a team as a code owner December 6, 2023 21:22
@jeffdaley jeffdaley marked this pull request as draft December 7, 2023 17:17
@jeffdaley jeffdaley changed the title Add ProjectStatusIcon component with color icons WIP: Add ProjectStatusIcon component with color icons Dec 14, 2023
@jeffdaley jeffdaley force-pushed the jeffdaley/add-project-status-icons branch from 00e5285 to 1a203c5 Compare December 21, 2023 01:56
@@ -9,7 +9,11 @@
@query={{hash status=status.value}}
class="hds-button hds-button--color-secondary"
>
<FlightIcon @name={{get-project-status-icon status.value}} class="mr-1" />
{{#if (eq status.value @status)}}
<FlightIcon @name={{get-project-status-icon status.value}} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the active state we keep the monochrome icon.

@jeffdaley jeffdaley changed the title WIP: Add ProjectStatusIcon component with color icons Add ProjectStatusIcon component with color icons Dec 21, 2023
@jeffdaley jeffdaley marked this pull request as ready for review December 21, 2023 02:05
@jeffdaley jeffdaley merged commit a4ec9f1 into main Dec 21, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/add-project-status-icons branch December 21, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants