Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dashboard from template to component #432

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 16, 2023

Creates a Dashboard component out of the current template and controller. This would generally be the first step in any Dashboard changes, so I wanted to isolate it to make future diffs easier.

@jeffdaley jeffdaley marked this pull request as ready for review November 16, 2023 17:16
@jeffdaley jeffdaley requested a review from a team as a code owner November 16, 2023 17:16
Copy link
Collaborator

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of high-level questions:

  • Why are component-izing the dashboard? Is this component going to be reused somewhere else?
  • Any reason we're not using the single-file component style? (I thought we were moving to that?)

@jeffdaley
Copy link
Contributor Author

  1. We've component-ized almost every template by now. Working with co-located files is more comfortable than jumping between folders. It also keeps routes and controllers focused only on redirecting, queryParams and models, with components doing everything else.
  2. Unfortunately gts is a little rough with our version of Ember (or at least my setup). I'm not getting import suggestions which makes writing stuff like {{#if (or this.isSelected (eq this.count 3))}} more difficult than it currently is. I'm still gonna try to use it, but it seems safer on lower-level components than Big Daddies.

@jfreda
Copy link
Collaborator

jfreda commented Nov 21, 2023

  • We've component-ized almost every template by now. Working with co-located files is more comfortable than jumping between folders. It also keeps routes and controllers focused only on redirecting, queryParams and models, with components doing everything else.
  • Unfortunately gts is a little rough with our version of Ember (or at least my setup). I'm not getting import suggestions which makes writing stuff like {{#if (or this.isSelected (eq this.count 3))}} more difficult than it currently is. I'm still gonna try to use it, but it seems safer on lower-level components than Big Daddies.

Okay works for me, thanks 👍

@jeffdaley jeffdaley merged commit 861e5be into main Nov 21, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/dashboard-columns branch November 21, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants