Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dockerfile to build image #42

Closed
wants to merge 7 commits into from

Conversation

trungdlp-wolffun
Copy link

@trungdlp-wolffun trungdlp-wolffun commented Feb 10, 2023

Issue: #8

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

.dockerignore Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@inductor
Copy link

@trungdlp-wolffun added some Dockerfile improvements including latest specification in https://docs.docker.com/engine/reference/builder/#copy---link

trungdlp-wolffun and others added 5 commits February 10, 2023 20:07
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
@trungdlp-wolffun
Copy link
Author

@inductor I'm updated your suggestion. Can you help me understand COPY --link meaning ? (I already read Docker document)

@inductor
Copy link

@trungdlp-wolffun https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#copy---link would probably have a better explanation.

It has better caching than without it

Dockerfile Outdated Show resolved Hide resolved
@trungdlp-wolffun trungdlp-wolffun requested a review from a team as a code owner February 13, 2023 04:36
@sjbarag
Copy link

sjbarag commented Apr 28, 2023

Any updates here? Having a Dockerfile upstream would make Hermes much easier to deploy!

@jeffdaley
Copy link
Contributor

Hey all, thanks for the contributions.

Unfortunately we're not accepting Dockerfile PRs right now, but this is planned work. Basically, we have internal, build-related things to configure first.

We appreciate your continued patience on this.

@jeffdaley jeffdaley closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants