-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dockerfile to build image #42
Conversation
@trungdlp-wolffun added some Dockerfile improvements including latest specification in https://docs.docker.com/engine/reference/builder/#copy---link |
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
Co-authored-by: Kohei Ota (inductor) <[email protected]>
@inductor I'm updated your suggestion. Can you help me understand |
@trungdlp-wolffun https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#copy---link would probably have a better explanation. It has better caching than without it |
Any updates here? Having a Dockerfile upstream would make Hermes much easier to deploy! |
Hey all, thanks for the contributions. Unfortunately we're not accepting Dockerfile PRs right now, but this is planned work. Basically, we have internal, build-related things to configure first. We appreciate your continued patience on this. |
Issue: #8