Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RequestReviewModal Buttons and Inputs #39

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Improve RequestReviewModal Buttons and Inputs #39

merged 2 commits into from
Feb 13, 2023

Conversation

jeffdaley
Copy link
Contributor

Improves the "Request review" modal. How?

  • docType.checks checkbox stays checked while the requestReview task runs.
  • PeopleSelect and docType.checks checkbox are disabled while the requestReview task runs.
  • The PeopleSelect label more accurately describes its function.

@jeffdaley jeffdaley requested a review from a team as a code owner February 13, 2023 14:27
@jeffdaley jeffdaley merged commit 4e3523f into main Feb 13, 2023
@jeffdaley jeffdaley deleted the jeffdaley/fix-modal-checkbox branch February 13, 2023 20:18
anuragprafulla referenced this pull request in razorpay/hermes Jun 27, 2023
@jeffdaley
Improve RequestReview modal buttons/inputs (#39)
67625b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubhavmishra anubhavmishra anubhavmishra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @anubhavmishra