Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondaryFilterAttribute to DropdownList #349

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Add secondaryFilterAttribute to DropdownList #349

merged 2 commits into from
Sep 26, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Sep 26, 2023 •
edited
Loading

Adds a secondaryFilterAttribute argument to the DropdownList so items can be filtered by additional information. For example, in the ProductSelect, we now match abbreviation in addition to productAreaName:

CleanShot 2023-09-26 at 16 20 42@2x

*Avatar designs placeholder

@jeffdaley jeffdaley requested a review from a team as a code owner September 26, 2023 20:37
@jeffdaley jeffdaley added the enhancement New feature or request label Sep 26, 2023
jfreda
jfreda approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@jeffdaley jeffdaley merged commit e180132 into main Sep 26, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/secondary-dropdown-filters branch September 26, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda