Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace back button with Hermes button #347

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Sep 26, 2023

Replaces the "← Dashboard" button on the document sidebar with a "Hermes" link.

Although the text said "Dashboard," the back arrow implied contextual awareness, i.e., that clicking it could navigate to the previous screen, even if it wasn't the dashboard. I think the new affordance clears things up:

CleanShot 2023-09-25 at 20 49 54@2x (Shown with hover outline)

@jeffdaley jeffdaley requested a review from a team as a code owner September 26, 2023 00:56
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jeffdaley jeffdaley merged commit d0d6c51 into main Sep 26, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/hermes-back-button branch September 26, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants