Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notification width and out animation #346

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update notification width and out animation #346

merged 1 commit into from
Sep 26, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Sep 25, 2023 •
edited
Loading

Fixes a couple FlashNotification bugs:

  • Notifications are now fixed width rather than fit-content avoiding a case where stacked notifications would be different -widths:
CleanShot 2023-09-25 at 09 40 15@2x
  • The notificationOut animation now works as expected. Currently you have to mouseover the div to trigger it.

@jeffdaley jeffdaley marked this pull request as ready for review September 25, 2023 17:13
@jeffdaley jeffdaley requested a review from a team as a code owner September 25, 2023 17:13
@jeffdaley jeffdaley changed the title Update notification styles Update notification width and out animation Sep 25, 2023
jfreda
jfreda approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@jeffdaley jeffdaley merged commit 4898d63 into main Sep 26, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/flash-notification branch September 26, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda