Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus PeopleSelects in the sidebar #333

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

jeffdaley
Copy link
Contributor

Fixes a bug where clicking an EditableField+PeopleSelect wouldn't focus it as expected.

@jeffdaley jeffdaley requested a review from a team as a code owner September 8, 2023 19:59
@jeffdaley jeffdaley force-pushed the jeffdaley/people-select-autofocus branch from 9770500 to 4cf1ecb Compare September 8, 2023 19:59
Comment on lines +20 to +21
renderInPlace?: boolean;
disabled?: boolean;
Copy link
Contributor Author

@jeffdaley jeffdaley Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened to come across these missing types. SORRY

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +20 to +21
renderInPlace?: boolean;
disabled?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffdaley jeffdaley merged commit df5cce8 into main Sep 18, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/people-select-autofocus branch September 18, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants