Related Resources refactor and External Link scope
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
scope
jeffdaley
commented
Sep 7, 2023
| @@ -299,7 +299,6 @@ | |||
| @documentIsDraft={{this.isDraft}} | |||
| @productArea={{@document.product}} | |||
| @objectID={{@document.objectID}} | |||
| @allowAddingExternalLinks={{true}} | |||
There was a problem hiding this comment.
This is now the default setting.
jeffdaley
commented
Sep 7, 2023
| @resource={{this.externalLink}} | ||
| @hideModal={{this.hideModal}} | ||
| @onClose={{this.hideModal}} |
There was a problem hiding this comment.
Renamed to be consistent with the argument Modal expects.
jeffdaley
commented
Sep 7, 2023
web/app/components/related-resources/add-or-edit-external-resource-modal.ts
Outdated
Show resolved
Hide resolved
jeffdaley
commented
Sep 7, 2023
jeffdaley
force-pushed
the
jeffdaley/related-resources
branch
from
f90f6e5
to
925d7ed
Compare
jfreda
approved these changes
Sep 26, 2023
| @@ -6,6 +6,8 @@ | |||
| </div> | |||
| {{else}} | |||
| <ul class="related-resources-list" ...attributes> | |||
| {{! This is being looped through twice for some reason... }} | |||
| {{! On immediate save, the order is wrong - maybe an array push thing? }} | |||
There was a problem hiding this comment.
Should we follow up on this (/add a TODO)?
There was a problem hiding this comment.
This was actually resolved and I forgot to remove the comment. Thanks for catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors and expands the RelatedResources component so it can be used outside of the DocumentSidebar context/format.
/components/documents/sidebar→/componentsscopeto skip remove the "search Algolia" functionality. (There's also a document scope that replacesallowAddingExternalLinks=false),scopedandfallbackcases