Add more detail around Algolia #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following the README I attempted to start the application without Algolia. When I went back and updated it was a bit unclear where the configuration was needed since there are three areas where config is added: 1. At build time via ENV for web app 2. At runtime via the Google credentials.json file 3. At runtime via the config.hcl file
|
|
jeffdaley
approved these changes
Jun 13, 2023
|
Good call @jrschumacher Thanks for your contribution! |
anuragprafulla
referenced
this pull request
in razorpay/hermes
Jun 27, 2023
* Add more detail around Algolia When following the README I attempted to start the application without Algolia. When I went back and updated it was a bit unclear where the configuration was needed since there are three areas where config is added: 1. At build time via ENV for web app 2. At runtime via the Google credentials.json file 3. At runtime via the config.hcl file * Update README.md * Update README.md --------- Co-authored-by: Jeff Daley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the README I attempted to start the application without Algolia. When I went back and updated it was a bit unclear where the configuration was needed since there are three areas where config is added: