Move table sorting function to column header #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the Sort dropdowns on the
/all,/myand/draftsroutes with interactive table headers. Currently only the "Created" column is sortable but the long-term goal is for all table headers to be interactive.The
Table::SortableHeaderhas a larger API than we're currently using (e.g., ability to render a button instead of an anchor, the ability to pass in a custom sort function) in anticipation of new functionality we're prototyping. When those functions are implemented, test coverage will expand.Also cleans up some type errors on the Pagination components.