Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /all to /documents #306

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Change /all to /documents #306

merged 13 commits into from
Sep 1, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Aug 24, 2023

Moves the "All Docs" route from /all to /documents to give us a better framework to add new models, e.g., projects, products, teams, that can be browsed. References to the /all route are now redirected to /documents.

@jeffdaley jeffdaley requested a review from a team as a code owner August 24, 2023 15:16
@jeffdaley jeffdaley changed the title Change all to all/documents Change /all to /documents Aug 25, 2023
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add an acceptance test for the redirect? (not sure offhand if this is possible, but if so, it might be able to catch regressions)

web/app/controllers/authenticated/all.ts Show resolved Hide resolved
@jeffdaley
Copy link
Contributor Author

Do you think we should add an acceptance test for the redirect?

Thanks for catching this. I wrote one in my spike branch but forgot to bring it over. ✅

@jeffdaley jeffdaley merged commit 8998855 into main Sep 1, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/explore branch September 1, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants