Add database updates to APIs #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type custom field: Name: cannot be blank' errors
anubhavmishra
approved these changes
Aug 23, 2023
| "path", r.URL.Path, | ||
| "doc_id", docID, | ||
| ) | ||
| // Don't return an HTTP error because the database isn't the source of |
There was a problem hiding this comment.
Maybe we can mark this as a TODO just so we can track it when we introduce the new API?
There was a problem hiding this comment.
I was thinking that this would never change in this file - the new version of the API will be a different file and this file will just be deleted. I'll remember to return an HTTP error for v2 🙂
| "path", r.URL.Path, | ||
| "doc_id", docID, | ||
| ) | ||
| // Don't return an HTTP error because the database isn't the |
There was a problem hiding this comment.
Same comment as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to current APIs to make database updates in addition to Algolia updates, as we migrate to the database being the source of truth for this information. Database errors for these APIs won't return HTTP errors and instead just log them because this data (in the DB) isn't critical yet.