Add support for single-file components #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Aug 18, 2023
Comment on lines
+10
to
+16
| export default class ActionComponent extends Component<ActionComponentSignature> { | ||
| <template> | ||
| <button type="button" class="action" ...attributes> | ||
| {{yield}} | ||
| </button> | ||
| </template> | ||
| } |
There was a problem hiding this comment.
The short-term downside of .gts is that GitHub doesn't have syntax highlighting yet.
There was a problem hiding this comment.
Looks like we should be able to configure this using an override in a .gitattributes file 🙌
jfreda
approved these changes
Sep 1, 2023
Comment on lines
+10
to
+16
| export default class ActionComponent extends Component<ActionComponentSignature> { | ||
| <template> | ||
| <button type="button" class="action" ...attributes> | ||
| {{yield}} | ||
| </button> | ||
| </template> | ||
| } |
There was a problem hiding this comment.
Looks like we should be able to configure this using an override in a .gitattributes file 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for template imports, i.e., single-file components, and converts
action.hbs/tstoaction.gts.Single-file components are are expected to be the recommended authoring format for Ember 5x; might as well get good seats on that train (source: Ember Blog).
Guided by ▶ EmberConf 2023 - Getting Started with 'template' Tag Components by Ignace Maes which also does a good job showing the benefits of this new format, such as locally defined components (shown below). It should boost DX, reduce file count, and make code review easier.