Add version and revision in config response #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
commented
Aug 17, 2023
| // commit or checkout revision | ||
| // from build information | ||
| func GetShortRevision() string { | ||
| if info, ok := debug.ReadBuildInfo(); ok { |
There was a problem hiding this comment.
Go 1.18 supports version control information. https://pkg.go.dev/runtime/debug#ReadBuildInfo
|
LGTM! Is revision the same as SHA? If so, my preference would be to call it a SHA, since that's what we've been referring to it internally as. But I'm also happy to learn a new term. Aside: TIL 7-char SHAs redirect to the full URL. |
jeffdaley
approved these changes
Aug 17, 2023
|
@jeffdaley Yea, I thought about this and settled on revision. Wanted to follow what Golang suggests |
jfreda
reviewed
Aug 23, 2023
Co-authored-by: Josh Freda <[email protected]>
jfreda
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
versionandshort_revisionin the/api/v1/web/configAPI response.Note: This change won't affect the
hermes versioncommand output. It will continue showing the version number of the application.