Delete hermes-urls.d.ts #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Aug 8, 2023
| export const HERMES_GITHUB_REPO_URL: string; | ||
| export const TEST_SUPPORT_URL: string; | ||
| export const TEST_SHORT_LINK_BASE_URL: string; | ||
| } |
There was a problem hiding this comment.
I shouldn't have been trying to export consts from a d.ts in the first place.
There was a problem hiding this comment.
I made this to appease Mirage but it turns out not to need it.
jfreda
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes problematic
d.tsfile causing build problems on staging.