Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of MM/DD/YYYY #27

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Replace uses of MM/DD/YYYY #27

merged 8 commits into from
Feb 8, 2023

Conversation

jeffdaley
Copy link
Contributor

Replaces MM/DD/YYYY-formatted timestamps with less ambiguous and more readable style:

In table rows:
12/21/23 → 21 Dec. 2023

In the document sidebar:
12/21/23 (14 days ago) → 21 December 2023

@jeffdaley jeffdaley marked this pull request as draft February 7, 2023 23:05
@jeffdaley jeffdaley marked this pull request as ready for review February 8, 2023 17:40
jfreda
jfreda approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ 🎉

@jeffdaley jeffdaley merged commit b530027 into main Feb 8, 2023
@jeffdaley jeffdaley deleted the jeffdaley/time-formatting branch February 8, 2023 20:05
anuragprafulla referenced this pull request in razorpay/hermes Jun 27, 2023
@jeffdaley
Replace uses of MM/DD/YYYY (#27)
4ea0090 
* Replace uses of MM/DD/YYYY

* Add `ember-dayjs`

* Convert to ember-dayjs

* Revert "Convert to ember-dayjs"

This reverts commit d43358c.

* Revert "Add `ember-dayjs`"

This reverts commit cb8d5ed.

* Remove broken assertion

* Documentation tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda