Add TooltipIcon component to Related Resources #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jul 20, 2023
| @@ -276,7 +276,7 @@ | |||
| @allowAddingExternalLinks={{true}} | |||
| @headerTitle="Related resources" | |||
| @modalHeaderTitle="Add related resource" | |||
| @modalInputPlaceholder="Paste a URL or search documents..." | |||
| @modalInputPlaceholder="Search docs or paste a URL..." | |||
There was a problem hiding this comment.
Reversed the order to be consistent with the tooltip text.
jeffdaley
commented
Jul 20, 2023
| @@ -283,7 +294,7 @@ export default class TooltipModifier extends Modifier<TooltipModifierSignature> | |||
| middleware: [ | |||
| offset(8), | |||
| flip(), | |||
| shift(), | |||
| shift({ padding: 20 }), | |||
There was a problem hiding this comment.
This prevents the tooltip from hitting the edge of the viewport by 20px.
jeffdaley
commented
Jul 20, 2023
| @@ -163,6 +177,7 @@ module( | |||
| @headerTitle="Test title" | |||
| @modalHeaderTitle="Add related resource" | |||
| @modalInputPlaceholder="Paste a URL or search documents..." | |||
| @scrollContainer={{this.body}} | |||
There was a problem hiding this comment.
These lines fix Glint errors in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic TooltipIcon component and implements it on the RelatedResources component.