Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve adding external resources via keyboard #258

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Improve adding external resources via keyboard #258

merged 2 commits into from
Jul 17, 2023

Conversation

jeffdaley
Copy link
Contributor

Improvements to

  • Errors when enter-submitting an untitled external resource via the "search or paste" input
  • Enter-to-submit functionality on the add-external-resource screen's title input
  • Reenabling keyboard navigation when a DropdownList's input regains focus

@jeffdaley jeffdaley marked this pull request as ready for review July 17, 2023 15:46
@jeffdaley jeffdaley requested a review from a team as a code owner July 17, 2023 15:46
@jeffdaley jeffdaley changed the title Improve adding external resources Improve adding external resources via keyboard Jul 17, 2023
@jeffdaley jeffdaley added enhancement New feature or request bugfix labels Jul 17, 2023
@jeffdaley jeffdaley merged commit c54bede into main Jul 17, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/related-resources-keyboard-support branch July 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
bugfix enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda