Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related resources API #257

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Add related resources API #257

merged 5 commits into from
Jul 12, 2023

Conversation

jfreda
Copy link
Contributor

@jfreda jfreda commented Jul 11, 2023

This PR adds data models and an API for getting and replacing related resources for a document.

New API endpoints

  • /api/v1/documents/{document_id}/related-resources
    • GET
    • PUT/POST (both replace all related resources for the document)

New database tables

  • document_related_resources
  • document_related_resource_external_links
  • document_related_resource_hermes_documents

@jfreda jfreda requested a review from a team as a code owner July 11, 2023 03:50
anubhavmishra
anubhavmishra approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@anubhavmishra anubhavmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me! Left a few comments.

@jfreda @anubhavmishra
More descriptive error message
3e5e92d 
Co-authored-by: Anubhav Mishra <[email protected]>
@jfreda jfreda merged commit 911c0fe into main Jul 12, 2023
1 check passed
@jfreda jfreda deleted the jfreda/add-related-resources-api branch July 12, 2023 15:21
@jfreda jfreda added the enhancement New feature or request label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubhavmishra anubhavmishra anubhavmishra approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfreda @anubhavmishra