Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search results; improve product-link logic on results screen #24

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Feb 3, 2023

  • Fixes a search-results bug that prevented queries from reaching the AlgoliaService
  • Fixes a bug where the pageNumber wouldn't reset when starting a new query
  • Fixes a bug where searching from the results page wouldn't refresh the results
  • Makes it so the "View all PRODUCT documents →" link only appears 1) on the first page; and 2) when queries match a product. Our current approach of showing the product associated with the first result is often inaccurate, and it's confusing to see it change on every screen.

@jeffdaley jeffdaley merged commit ef1b593 into main Feb 3, 2023
@jeffdaley jeffdaley deleted the jeffdaley/search-results branch February 3, 2023 20:42
anuragprafulla referenced this pull request in razorpay/hermes Jun 27, 2023
Fix search results; improve product-link logic on results screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants