Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DropdownList Types #225

Merged
merged 20 commits into from
Jun 26, 2023
Merged

Improve DropdownList Types #225

merged 20 commits into from
Jun 26, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Jun 16, 2023 •
edited
Loading

  • Updates the X::DropdownList types to work with Glint.
  • Removes a bunch of @glint-nochecks.
  • Minor fixes and (1) property rename (hideDropdown → hideContent to be consistent with FloatingUI API)

@jeffdaley
Merge branch 'main' into jeffdaley/dropdown-list-types
9eba57f
@jeffdaley
rename isSelected
6750743
@jeffdaley
Improve types
31274de
@jeffdaley
Rename selected → isSelected
a691a52
@jeffdaley
Renames some test properties
80c286d
@jeffdaley
Update index.hbs
07273b2
@jeffdaley
Merge branch 'jeffdaley/rename-selected' into jeffdaley/dropdown-list…
13e4efc 
…-types
@jeffdaley
Update index.hbs
bf02008
@jeffdaley
More renames
41b8aab
@jeffdaley
Merge branch 'jeffdaley/rename-selected' of https://github.com/hashic…
c7a2941 
…orp-forge/hermes into jeffdaley/rename-selected
@jeffdaley
Additional renames
30d058f
@jeffdaley
More renames
e7aa937
@jeffdaley
Update test
751c7e6
@jeffdaley
Merge branch 'jeffdaley/rename-selected' into jeffdaley/dropdown-list…
2be81df 
…-types
@jeffdaley
Merge branch 'main' into jeffdaley/dropdown-list-types
1bf8905
@jeffdaley
Created shared-types file; cleanup
f7d7fb2
@jeffdaley
Fix import
6f79c32
@jeffdaley
Tweak query definition
c2fc4a7
@jeffdaley jeffdaley marked this pull request as ready for review June 23, 2023 19:58
@jeffdaley jeffdaley requested a review from a team as a code owner June 23, 2023 19:58
@jeffdaley jeffdaley merged commit 0f1b7d1 into main Jun 26, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/dropdown-list-types branch June 26, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda