Lock documents on other types of suggestions in the header #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+92
to
+96
| if ft == draftsFolderType { | ||
| log.Info(fmt.Sprintf("locked draft document IDs: %v", lockedDocIDs)) | ||
| } else { | ||
| log.Info(fmt.Sprintf("locked document IDs: %v", lockedDocIDs)) | ||
| } |
anubhavmishra
approved these changes
Jun 14, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…-forge#212) * Lock documents on other types of suggestions in the header * Separate log line for locked draft docs * Add comments per PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #182 to lock documents when there are other types of suggestions in the header (which causes the same issue: #181).