-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New::DocForm
updates: TypeScript, error handling, documentation, discourage long summaries
#21
Conversation
New::DocForm
updates: TypeScript, error handling, documentation, discourage long summaries
export interface DocumentPerson { | ||
email: string; | ||
imgURL: string | null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to web/app/types/document.d.ts
…-forge/hermes into jeffdaley/new-doc-form
web/app/components/new/doc-form.ts
Outdated
}), | ||
}); | ||
|
||
throw new Error(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this for testing and should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅😬🫠 thanks for catching
…scourage long summaries (#21) * Type DocForm; Discourage long summaries; Cleanup * Cleanup * Rearrange interfaces * Update yarn.lock * Cleanup * Refactor updateFormElements actions * Refactor updateFormElements actions * Add comment * Update doc-form.ts
Makes the following changes to the
New::DocForm
:PeopleSelect
componentcreateDoc
error (shows flashMessage; preserves formFields)Plus some renaming, for clarity :-)
CleanShot.2023-02-02.at.18.07.08.mp4