Type Doc components #207
Merged
Type Doc components #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 8, 2023
| @@ -18,8 +19,10 @@ | |||
|
|
|||
| <Person @ignoreUnknown={{true}} @imgURL={{@avatar}} @email={{@owner}} /> | |||
|
|
|||
| {{#if (and @isResult @snippet)}} | |||
There was a problem hiding this comment.
Need to investigate this. Glint thought @snippet was undefined despite it passing the if ... and check.
jfreda
approved these changes
Jun 8, 2023
web/app/components/doc/row.ts
Outdated
| get productAreaName() { | ||
| let productAreaName; | ||
|
|
||
| // TODO: Convert this to a switch statement |
There was a problem hiding this comment.
I thought we had a helper for this logic somewhere 🤔
There was a problem hiding this comment.
Ah right, yeah we have one for the icon.
This one just needs to be cleaned up (and, separately, turned into its own helper).
Remove unnecessary code
jeffdaley
force-pushed
the
jeffdaley/register-doc-components
branch
from
fdd0ecf
to
414f5e0
Compare
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Type Doc components * Update row.ts * Update row.hbs Remove unnecessary code * Update row component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types to the Doc components.