Type Sidebar #206
Merged
Type Sidebar #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 8, 2023
Comment on lines
-316
to
-368
| {{!-- <div class="flex flex-col items-start space-y-2 px-3"> | ||
| <small class="hds-typography-body-100 hds-foreground-faint">Tags</small> | ||
| {{#if this.isOwner}} | ||
| <EditableField | ||
| @value={{this.tags}} | ||
| @onChange={{perform this.save "tags"}} | ||
| @loading={{this.save.isRunning}} | ||
| > | ||
| <:default> | ||
| {{#if this.tags.length}} | ||
| <ol> | ||
| {{#each this.tags as |tag|}} | ||
| <li> | ||
| <FlightIcon | ||
| @name="tag" | ||
| @color="var(--token-color-palette-neutral-500)" | ||
| /> | ||
| {{tag}} | ||
| </li> | ||
| {{/each}} | ||
| </ol> | ||
| {{else}} | ||
| <em>No tags</em> | ||
| {{/if}} | ||
| </:default> | ||
| <:editing as |F|> | ||
| <Inputs::TagSelect | ||
| class="multiselect--narrow" | ||
| @selected={{this.tags}} | ||
| @onChange={{this.updateTags}} | ||
| {{click-outside (fn F.update this.tags)}} | ||
| /> | ||
| </:editing> | ||
| </EditableField> | ||
| {{else}} | ||
| {{#if this.tags.length}} | ||
| <ol> | ||
| {{#each this.tags as |tag|}} | ||
| <li> | ||
| <FlightIcon | ||
| @name="tag" | ||
| @color="var(--token-color-palette-neutral-500)" | ||
| /> | ||
| {{tag}} | ||
| </li> | ||
| {{/each}} | ||
| </ol> | ||
| {{else}} | ||
| <em>No tags</em> | ||
| {{/if}} | ||
| {{/if}} | ||
| </div> --}} | ||
|
|
There was a problem hiding this comment.
It's time. (Nothing here we can't easily replicate later if we want to implement tags.)
jfreda
approved these changes
Jun 8, 2023
web/app/types/document.d.ts
Outdated
| appCreated?: boolean; | ||
| contributors?: HermesUser[]; | ||
| approvers?: HermesUser[]; | ||
| changesRequestedBy?: unknown[]; // TODO: Define this |
There was a problem hiding this comment.
This should also be HermesUser[]
There was a problem hiding this comment.
Actually I'm inferring that it's a string[] like approvedBy:
get hasRequestedChanges() {
return this.args.document.changesRequestedBy?.includes(
this.args.profile.email
);
}
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Type sidebar file * Update document.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types to the Sidebar component.