Add most type definitions for most HDS components #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 7, 2023
| @@ -17,7 +16,7 @@ | |||
| <Hds::Link::Inline | |||
| @icon="external-link" | |||
| @iconPosition="trailing" | |||
| @hrefIsExternal={{true}} | |||
| @isHrefExternal={{true}} | |||
There was a problem hiding this comment.
Glint doing its job. (I'm sure I'll find more mistakes as we remove nochecks.
jfreda
approved these changes
Jun 8, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Add more definitions * Add ButtonSet block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mostly complete types for most of the HDS components we're using. For templates already type-checked by Glint, this removes many VSCode underlines and will allow make it much easier to remove
@glint-nocheckdeclarations.I generally skipped the component-like block yields for now, but hopefully we can make time to add them soon.