Save target url in SessionStorage for post-auth redirect; Add EmberSimpleAuth types #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jeffdaley
changed the title
jeffdaley
approved these changes
Feb 3, 2023
anuragprafulla
referenced
this pull request
in razorpay/hermes
Jun 27, 2023
Save target url in SessionStorage for post-auth redirect; Add EmberSimpleAuth types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember-simple-auth tracks the current transition in a service, but if you do a full redirect for authentication, that value isn't persisted anywhere.
This PR removes some code that I believe was trying to duplicate the ember-simple-auth functionality. It also adds an alternate method for maintaining the target url that uses the browser's SessionStorage API which does survive redirects.
The result of this is: if you're following a link from an email and aren't authenticated, you should get redirected to the target link after completing authentication.