Fix post-auth redirect (Google auth, testing environment) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 2, 2023
| @@ -188,7 +188,7 @@ export default class SessionService extends EmberSimpleAuthSessionService { | |||
| // Because we redirect as part of the authentication flow, the parameter storing the transition gets reset. Instead, we keep track of the redirectTarget in browser sessionStorage and override the handleAuthentication method as recommended by ember-simple-auth. | |||
|
|
|||
| handleAuthentication(routeAfterAuthentication: string) { | |||
| if (this.authenticatedUser.info) { | |||
| if (this.authenticatedUser._info) { | |||
There was a problem hiding this comment.
This is actually the property that can be null. The non-underscored version is asserted true.
jfreda
approved these changes
Jun 2, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…forge#194) Fix post-auth redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where clicking the "Authenticate with Google" button would throw an assertion while in the local environment.
We were incorrectly checking for the getter rather than the tracked property.