Fix logic to update recently viewed documents #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
approved these changes
May 19, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Fix logic to update recently viewed documents * Only update recently viewed docs for a draft view event when header is present * Pass 'Add-To-Recently-Viewed' header for draft view events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users' recently viewed documents were not being updated correctly in all cases. Taking a look at this logic again, I found that we weren't gating the updates of recently viewed docs for draft documents on when the
Add-To-Recently-Viewedheader is present (like we do for non-draft docs), which could potentially have strange consequences. Also the logic to update recently viewed docs itself wasn't sorting results correctly, which I believe was the main cause for the incorrect behavior.