Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FloatingUI offset #175

Merged
merged 1 commit into from
May 17, 2023

Conversation

jeffdaley
Copy link
Contributor

Adds support for custom FloatingUI offsets. Will be used by the search popover to align icons and type.

https://floating-ui.com/docs/offset

@jeffdaley jeffdaley marked this pull request as ready for review May 16, 2023 00:47
@jeffdaley jeffdaley requested a review from a team as a code owner May 16, 2023 00:47
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@jeffdaley jeffdaley merged commit 234828a into main May 17, 2023
@jeffdaley jeffdaley deleted the jeffdaley/add-offset-to-floating-ui branch May 17, 2023 00:44
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants