Add keyboard nav to search; improve search productArea suggestions #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 2, 2023
jeffdaley
commented
Jun 7, 2023
jfreda
reviewed
Jun 8, 2023
jeffdaley
force-pushed
the
jeffdaley/search-keyboard-nav
branch
from
5c7a965
to
11d98b7
Compare
@jeffdaley To do this, we'll want to change to |
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…ashicorp-forge#174) * Add product dropdown to draft template * Add tests * Start of custom popover * Start generic popover component * Organization * Maybe In Element * More API development * Fix type errors * Additional component work * Progress * Start of keyboard nav hookup * UX improvements, experiments * WIP - IDs * Minor refactor and cleanup * Update list.hbs * Reorganize FloatingUI components * Update content.ts * Improve loading strategy * Add `ember-element-helper` * Refactor dropdown list container * Template tweaks * Template and CSS cleanup * CSS cleanup * API tweak * Rename files * Rearrange files * Update index.hbs * Yield items to main component * Port facetDropdown to new Listbox * Yielded components; general refactors * Toggle components * Improved saving state * Class rearranging * Add sortBy component * Remove unused files * Update syntax * Improve tests passing * Update tests * FloatingUI API tweaks * Tweak FUI * Delete playground.hbs * Update config.ts * Rename/reorg * Remove references to `f.content` * Add comments to index * Additional classes and documentation * Clean up FacetDropdown * Move FacetDropdown tests to DropdownListIndex * Add aria test * Test Keyboard navigation * Test Enter key * Add keyboard tests * ToggleButton test * LinkTo, CheckableItem tests * CSS tweaks * Update list.scss * Add ToggleSelect and update NewDocForm * Improvements around productAbbreviations * Update checkable-item-test.ts * Fix scrolling issue * Update index.ts * Stop propigation on the DropdownList * Add product abbreviation to dropdown * Tweaked ProductDropdown * Improve ProductSelect dropdown * Replace ToggleSelect * Delete toggle-select.hbs * Clean up FloatDown API * Replace FacetDropdowns * Improve styling * Basic search keyboardFunctions done * Improved semantics of header * Improve model/query args; add Glint boilerplate * Contextual "Best matches" header * Improve popover styles * UX Improvements - Add floatingUIOffset - Improved empty-search handling - Improved keyboard handling - Improve productMatch suggestion - Improve enter-to-submit function * Update product/area link * Add support for offset * Removed commented-out code * Add and test LinkTo helpers * Tweak types, Glint boilerplate * Glint tweaks * Improve saving state * Cleanup * Glint-related updates * Glint types, todo test * Start of badgeDropdownList tests * Move tests to acceptance * Simplify glint-nochecks * Fix broken tests * Remove old code * Test fixes and improvements * File renames * Update docNumber function * Update badge-dropdown-list-test.ts * Update checkable-item.hbs * Update item.ts * BadgeDropdownList component * BadgeDropdownList component * Add custom-item test * Remove unnecessary comment * Update list-item.scss * Resolve merge conflict * ProductSelect component * Add list item tests * Tests, styles, cleanup * Add onChange test * Pass @ICON into component * Remove unused property * Remove unused property * Revert unintended change * Padding tweak; Prettier * Revert trivial change * Start of working tests * More tests * Fix failing tests * CSS tweaks * Cleanup * Cleanup and height tweaks * Class cleanup * Update factory type * Cleanup, documentation and UX improvements * Improve shouldRenderOut documentation * Fix broken tests * Add itemShouldRenderOut test * Remove need for separate index * Update Mirage responses and search tests * Make product facet searchable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keyboard-nav support to global search. Improves the accuracy and utility of the "View all [productName]" matches by searching productNames separately from the main search.
🚨 Algolia tweak: This requires the "product" facet on the primary index to be searchable.