Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http.StatusOK for w.WriteHeader #168

Merged
merged 1 commit into from
May 30, 2023

Conversation

syntaqx
Copy link
Contributor

@syntaqx syntaqx commented May 3, 2023

Minor little fix, but keeps the w.WriteHeader the same as other implementations in the code, and also because using 200 without the constant value makes me sad.

@syntaqx syntaqx requested a review from a team as a code owner May 3, 2023 18:37
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

using 200 without the constant value makes me sad.

@jfreda jfreda merged commit a2392b6 into hashicorp-forge:main May 30, 2023
@syntaqx syntaqx deleted the http-status-const branch June 20, 2023 18:42
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants