Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FacetDropdownList #166

Merged
merged 5 commits into from
May 17, 2023
Merged

Refactor FacetDropdownList #166

merged 5 commits into from
May 17, 2023

Conversation

jeffdaley
Copy link
Contributor

Converts the FacetDropdownList components to use X::DropdownList.

@jeffdaley jeffdaley requested a review from a team as a code owner May 2, 2023 18:51
jfreda
jfreda approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red! 😻

web/app/components/header/toolbar.hbs Outdated Show resolved Hide resolved
@jeffdaley jeffdaley merged commit 8aa382d into main May 17, 2023
@jeffdaley jeffdaley deleted the jeffdaley/replace-facet-dropdown-list branch May 17, 2023 00:51
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
@jeffdaley
Refactor FacetDropdownList (hashicorp-forge#166)
93f7d2b 
* Clean up FloatDown API

* Replace FacetDropdowns

* Improve styling

* Remove unused class property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda