Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary transition args #15

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Remove unnecessary transition args #15

merged 1 commit into from
Feb 10, 2023

Conversation

jeffdaley
Copy link
Contributor

Removes self-referential route information from the requestReview task. To transition queryParams without changing routes we can just write:

this.router.transitionTo({queryParams: { draft: false }});

Source:
Ember transitionTo docs

@jeffdaley jeffdaley merged commit 9142bb8 into main Feb 10, 2023
@jeffdaley jeffdaley deleted the jeffdaley/simplify-request-review-transition branch February 10, 2023 22:11
anuragprafulla referenced this pull request in razorpay/hermes Jun 27, 2023
@jeffdaley
Remove unnecessary transition args (#15)
3210483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda