Auth: Ignore saving certain transitions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Apr 12, 2023
| @@ -112,7 +112,7 @@ export default class SessionService extends EmberSimpleAuthSessionService { | |||
| } | |||
| } | |||
|
|
|||
| if (redirectTarget && redirectTarget !== "/authenticate") { | |||
There was a problem hiding this comment.
Moved this to the beforeModel check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores post-auth redirectTargets to the root and Authenticate routes. Fixes a bug causing valid redirects to be overwritten.
When you try to access an authenticated route, Ember Simple Auth restores your previous token, which, if expired, will cause the session to invalidate. By default, this reloads the Ember app in an effort to clear data. On refresh, the application beforeModel receives a new transition, this time to the application root. Currently we let this transition target through, overwriting the valid target. Now we ignore it :----)