Simplify session/localStorage logic; Add isLoggedIn check #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
force-pushed
the
jeffdaley/fix-redirect
branch
from
0ff7ed3
to
829f52d
Compare
anubhavmishra
approved these changes
Apr 6, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…forge#126) * Simplify session/localStorage logic; add isLoggedIn check * Revert application.js change * Add comment * Reduce diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the logic for saving session/localStorage redirect values.
Adds an
isLoggedIncheck to prevent a 401 that was bubbling up to the application error and triggering an unnecesary invalidate call. You can see in the screenshot that it's the previously unconditionalloadUserInfocall that's triggering the error and causing the session to invalidate: