Remove deleted drafts from Recently Viewed #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Mar 23, 2023
| }); | ||
|
|
||
| // Wait for document to be deleted. | ||
| yield wait(2000); |
There was a problem hiding this comment.
I don't think we need to wait for this since we're redirecting to a known route (unlike the new doc form).
jeffdaley
commented
Mar 23, 2023
| method: "DELETE", | ||
| headers: { "Content-Type": "application/json" }, | ||
| }) | ||
| .then((resp) => resp.json()) |
There was a problem hiding this comment.
Doesn't look like we're doing anything with the JSON. I've removed this call in TS version
jeffdaley
commented
Mar 23, 2023
| @@ -146,8 +146,6 @@ export default function (mirageConfig) { | |||
| * Used by the Document route to get a document. | |||
| */ | |||
| this.get("/documents/:document_id", (schema, request) => { | |||
| debugger; | |||
jeffdaley
commented
Mar 23, 2023
Comment on lines
+312
to
+315
| declare module "@ember/service" { | ||
| interface Registry { | ||
| "recently-viewed-docs": RecentlyViewedDocsService; | ||
| } |
There was a problem hiding this comment.
This is to allow aliasing in TS files, e.g., @service('recently-viewed-docs') declare recentDocs;
jfreda
approved these changes
Mar 23, 2023
jeffdaley
deleted the
jeffdaley/remove-deleted-docs-from-recently-viewed
branch
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Remove deleted drafts from RecentlyViewedDocs * Remove consoleLog * Remove `remove` :) * Update error * Enqueue the markViewed task * Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
fetchAllcall to thedeleteDrafttask to effectively remove it from the RecentlyViewedDocs list.Plus some cleanup and boilerplate.