Add exponential backoff to Google Drive list files call #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
approved these changes
Mar 23, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…rge#101) * Add default exponential backoff configuration and notify function * Retry with a default backoff config and notify function * Add exponential backoff to Google Drive list files call * Fix documents folder ID in log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exponential backoff to the Google Drive list files call, which seems to return an internal error relatively frequently. It also creates a default backoff configuration with a shorter max elapsed time of 2 minutes (the default is 15 minutes) and logs warnings when backoff errors are returned but we're still retrying.
And unrelatedly, it fixes a log line with the wrong folder ID.