Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oomnitza activities connector #23

Merged

Conversation

melissahardware
Copy link
Contributor

This PR is to add the Oomnitza activities connector. Oomnitza API doesn't have much documentation and had to build the connector from information given from support.

@melissahardware melissahardware requested a review from a team as a code owner May 10, 2023 22:08
hcpadkins
hcpadkins previously approved these changes May 11, 2023
Copy link
Contributor

@hcpadkins hcpadkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor documentation related notes, but otherwise this looks great. Nice work! 🚢

grove/connectors/oomnitza/activities.py Show resolved Hide resolved
grove/connectors/oomnitza/api.py Outdated Show resolved Hide resolved
grove/connectors/oomnitza/api.py Outdated Show resolved Hide resolved
cugu
cugu previously approved these changes May 11, 2023
@melissahardware melissahardware dismissed stale reviews from cugu and hcpadkins via 30c00c9 May 11, 2023 15:35
Copy link
Contributor

@hcpadkins hcpadkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. Great work again! 🚢

@cugu
Copy link
Contributor

cugu commented May 12, 2023

Nice work!

@melissahardware melissahardware merged commit 1b8c359 into hashicorp-forge:main May 16, 2023
@melissahardware melissahardware deleted the oomnitza-connector branch May 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants