Feat/hwc 203 appkit #1342
Draft
Feat/hwc 203 appkit #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
…r logging Signed-off-by: Mario Francia <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
tmctl
reviewed
Oct 9, 2025
Comment on lines
199
to
203
| return [ | ||
| HederaChainDefinition.Native.Mainnet, | ||
| HederaChainDefinition.Native.Testnet | ||
| ]; | ||
| } |
There was a problem hiding this comment.
@M-Francia for Utila, and any other ethereum JSON-RPC compatible app, you need to use the EIP Namespace: https://github.com/hashgraph/hedera-wallet-connect/blob/06975d99faca545e0e2ef6820d4312b8b7639a18/src/reown/utils/chains.ts#L60
tmctl
reviewed
Oct 9, 2025
| LogService.logTrace( | ||
| `Signature result: ${JSON.stringify(signResult, null, 2)}`, | ||
| ); | ||
| const signedTransaction = await this.hederaProvider!.hedera_signTransaction({ |
There was a problem hiding this comment.
@M-Francia this needs to be a function in the eip155 namespace, i.e eth_signTransaction
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist