Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using module-info.java in Build #4395

Merged
merged 23 commits into from
Dec 6, 2022
Merged

Using module-info.java in Build #4395

merged 23 commits into from
Dec 6, 2022

Conversation

hendrikebbers
Copy link
Member

No description provided.

@hendrikebbers hendrikebbers self-assigned this Dec 1, 2022
@hendrikebbers
automatic modules
e5daa31 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
automatic modules
1f9432b 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
Copy link
Member Author

grpc/grpc-java#3522
hamcrest/JavaHamcrest#269
google/truth#746
https://github.com/swirlds/swirlds-platform/issues/6388

@hendrikebbers
automatic modules
cd47ff9 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
automatic modules
164f75e 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
automatic modules
f99a003 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
automatic modules
5e89c57 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
spotless
35f2adc 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
deactivate some tests for now
dad0674 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
opens packages for reflection
c1d60d9 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers hendrikebbers added P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Java Pull requests that update Java code Improvement Code changes driven by non business requirements. CI:UnitTests Tech Debt Reduced Issues which reduce technical debt. Modularization Issues or PRs related to modularization labels Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 96.34% // Increases project coverage by +96.34% 🎉

Coverage data is based on head (366bf6f) compared to base (f20ae3a).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #4395       +/-   ##
==============================================
+ Coverage           0   96.34%   +96.34%     
- Complexity         0    15211    +15211     
==============================================
  Files              0     1041     +1041     
  Lines              0    43317    +43317     
  Branches           0     4365     +4365     
==============================================
+ Hits               0    41735    +41735     
- Misses             0      822      +822     
- Partials           0      760      +760
Impacted Files Coverage Δ
...hedera/node/app/service/mono/utils/NftNumPair.java 85.71% <0.00%> (ø)
.../precompile/impl/AbstractDissociatePrecompile.java 100.00% <0.00%> (ø)
...pp/hapi/utils/throttles/DeterministicThrottle.java 97.05% <0.00%> (ø)
...hedera/node/app/hapi/utils/fee/FileFeeBuilder.java 97.14% <0.00%> (ø)
...e/contracts/precompile/impl/IsTokenPrecompile.java 100.00% <0.00%> (ø)
.../mono/ledger/accounts/HederaAccountCustomizer.java 98.03% <0.00%> (ø)
...rvice/mono/ledger/accounts/ContractCustomizer.java 100.00% <0.00%> (ø)
...service/mono/legacy/core/jproto/JECDSA_384Key.java 100.00% <0.00%> (ø)
...de/app/service/mono/stream/NonBlockingHandoff.java 100.00% <0.00%> (ø)
...vice/mono/fees/calculation/EntityScaleFactors.java 100.00% <0.00%> (ø)
... and 1031 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hendrikebbers
modularization
04c80b3 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
modularization
2191c7a 
Signed-off-by: Hendrik Ebbers <[email protected]>
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hendrikebbers
develop merged
a0a6145 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
activate tests
b43d3ce 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
reverted tests
c853962 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
reverted tests
b1e5f3c 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers hendrikebbers marked this pull request as ready for review December 2, 2022 11:38
@hendrikebbers hendrikebbers requested a review from a team as a code owner December 2, 2022 11:38
@hendrikebbers
develop merged
938c95a 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers hendrikebbers mentioned this pull request Dec 2, 2022
Merged
@hendrikebbers
spotless
0ff897b 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
develop merged
132356f 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
develop merged
5333b02 
Signed-off-by: Hendrik Ebbers <[email protected]>
@hendrikebbers
spotless
366bf6f 
Signed-off-by: Hendrik Ebbers <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hendrikebbers hendrikebbers merged commit bee452c into develop Dec 6, 2022
@hendrikebbers hendrikebbers deleted the 04343-D-missing-requires branch December 6, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srkswirlds srkswirlds srkswirlds approved these changes

@mhess-swl mhess-swl mhess-swl approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@tinker-michaelj tinker-michaelj Awaiting requested review from tinker-michaelj

@rbair23 rbair23 Awaiting requested review from rbair23

@netopyr netopyr Awaiting requested review from netopyr

Assignees

@hendrikebbers hendrikebbers

Labels
Improvement Code changes driven by non business requirements. Java Pull requests that update Java code Modularization Issues or PRs related to modularization P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikebbers @Neeharika-Sompalli @mhess-swl @srkswirlds