Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare runbook scripts for backup being enabled #9998

Merged

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Dec 21, 2024

Description:

Prepare script changes for backup being enabled

  • Clean up backup resources when restoring a volume snapshot
  • Move some duplicate code to utils

Related issue(s):

Fixes #9588

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

prepare script changes for backup being enabled

Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 linked an issue Dec 21, 2024 that may be closed by this pull request
@jnels124 jnels124 self-assigned this Dec 21, 2024
@jnels124 jnels124 added the enhancement Type: New feature label Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (8639460) to head (891f5cc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9998   +/-   ##
=========================================
  Coverage     92.33%   92.33%           
+ Complexity     7753     7752    -1     
=========================================
  Files           938      938           
  Lines         32663    32663           
  Branches       4131     4131           
=========================================
  Hits          30159    30159           
- Misses         1533     1534    +1     
+ Partials        971      970    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnels124 jnels124 added this to the 0.121.0 milestone Dec 21, 2024
@jnels124 jnels124 added the database Area: Database label Dec 21, 2024
@jnels124 jnels124 marked this pull request as ready for review December 21, 2024 00:16
@jnels124 jnels124 requested a review from a team as a code owner December 21, 2024 00:16
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 requested a review from xin-hedera January 2, 2025 23:37
Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 9e6b585 into main Jan 3, 2025
35 of 36 checks passed
@steven-sheehy steven-sheehy deleted the 9588-update-runbook-for-restoring-volume-snapshot branch January 3, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Area: Database enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Runbook For Restoring Volume Snapshot
3 participants