Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI spec response schema for getTopicMessageByIdAndSequenceNumber #9991

Conversation

xin-hedera
Copy link
Collaborator

Description:

This PR fixes the OpenAPI spec response schema for /api/v1/topics/{topicId}/messages/{sequenceNumber}

Related issue(s):

Fixes #9990

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera added bug Type: Something isn't working documentation Type: Improvements or additions to documentation rest Area: REST API labels Dec 19, 2024
@xin-hedera xin-hedera added this to the 0.121.0 milestone Dec 19, 2024
@xin-hedera xin-hedera self-assigned this Dec 19, 2024
@xin-hedera xin-hedera requested a review from a team as a code owner December 19, 2024 23:16
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (1423952) to head (7a47961).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9991   +/-   ##
=========================================
  Coverage     92.23%   92.23%           
  Complexity     7856     7856           
=========================================
  Files           956      956           
  Lines         32896    32896           
  Branches       4148     4148           
=========================================
  Hits          30341    30341           
  Misses         1579     1579           
  Partials        976      976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-sheehy steven-sheehy removed the bug Type: Something isn't working label Dec 20, 2024
@xin-hedera xin-hedera merged commit 96992a3 into main Dec 20, 2024
32 checks passed
@xin-hedera xin-hedera deleted the 9990-incorrect-response-format-in-openapi-spec-for-apiv1topicstopicidmessagessequencenumber branch December 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Type: Improvements or additions to documentation rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect response format in OpenAPI spec for /api/v1/topics/{topicId}/messages/{sequenceNumber}
2 participants