Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round down fee in tinybars #9973

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Round down fee in tinybars #9973

merged 4 commits into from
Dec 17, 2024

Conversation

xin-hedera
Copy link
Collaborator

@xin-hedera xin-hedera commented Dec 17, 2024 •
edited
Loading

Description:

This PR fixes the inconsistent fee issue

  • Round down when converting gas price to fee in tinybars

Related issue(s):

Fixes #9942

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera self-assigned this Dec 17, 2024
@xin-hedera xin-hedera linked an issue Dec 17, 2024 that may be closed by this pull request
Mirror and Consensus Nodes use different rounding strategies when converting gas fees from cents to tinybars #9942
Closed
@xin-hedera xin-hedera added bug Type: Something isn't working rest Area: REST API labels Dec 17, 2024
@xin-hedera xin-hedera added this to the 0.121.0 milestone Dec 17, 2024
@xin-hedera xin-hedera marked this pull request as ready for review December 17, 2024 16:18
@xin-hedera xin-hedera requested a review from a team as a code owner December 17, 2024 16:18
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (fcd2790) to head (0874c3b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9973      +/-   ##
============================================
+ Coverage     92.21%   92.31%   +0.09%     
+ Complexity     7840     7737     -103     
============================================
  Files           954      936      -18     
  Lines         32791    32537     -254     
  Branches       4141     4121      -20     
============================================
- Hits          30238    30035     -203     
+ Misses         1581     1535      -46     
+ Partials        972      967       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edwin-greene
edwin-greene approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xin-hedera xin-hedera merged commit 26878b7 into main Dec 17, 2024
32 checks passed
@xin-hedera xin-hedera deleted the 9942-mirror-and-consensus-nodes-use-different-rounding-strategies-when-converting-gas-fees-from-cents-to-tinybars branch December 17, 2024 18:26
@steven-sheehy steven-sheehy mentioned this pull request Jan 15, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwin-greene edwin-greene edwin-greene approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

Assignees

@xin-hedera xin-hedera

Labels
bug Type: Something isn't working rest Area: REST API
Projects
None yet
Milestone
0.121.0
Development

Successfully merging this pull request may close these issues.

Mirror and Consensus Nodes use different rounding strategies when converting gas fees from cents to tinybars
3 participants
@xin-hedera @steven-sheehy @edwin-greene