Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP 904 add token associate on claim airdrop (0.119) #9872

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Cherry pick of #9841 to release/0.119.

  • Associates a token when a claim airdrop occurs
  • Change balance generation transaction timeout from 5m to 10m
  • Handle scenario where user manually associates token before claiming

Related issue(s):

Fixes #9865

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Associates a token when a claim airdrop occurs
* Change balance generation transaction timeout from 5m to 10m
* Handle scenario where user manually associates token before claiming

---------

Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added bug Type: Something isn't working parser Area: File parsing hts Hedera Token Service labels Dec 4, 2024
@steven-sheehy steven-sheehy added this to the 0.119.0 milestone Dec 4, 2024
@steven-sheehy steven-sheehy self-assigned this Dec 4, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner December 4, 2024 22:51
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (71e23ee) to head (b461d36).
Report is 1 commits behind head on release/0.119.

Files with missing lines Patch % Lines
.../AbstractTokenUpdateAirdropTransactionHandler.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.119    #9872   +/-   ##
================================================
  Coverage            92.27%   92.28%           
- Complexity            7771     7777    +6     
================================================
  Files                  951      951           
  Lines                32468    32492   +24     
  Branches              4116     4119    +3     
================================================
+ Hits                 29959    29984   +25     
+ Misses                1545     1544    -1     
  Partials               964      964           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 00412fd into release/0.119 Dec 4, 2024
31 checks passed
@steven-sheehy steven-sheehy deleted the hip904-add-token-associate-119 branch December 4, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working hts Hedera Token Service parser Area: File parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants