Rename CustomCallOperation #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
IvanKavaldzhiev,
steven-sheehy,
nickeynikolovv and
bilyana-gospodinova
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9782 +/- ##
=========================================
Coverage 92.25% 92.25%
Complexity 7769 7769
=========================================
Files 950 950
Lines 32450 32450
Branches 4113 4113
=========================================
+ Hits 29936 29937 +1
Misses 1546 1546
+ Partials 968 967 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
steven-sheehy
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when trying to run transaction using Reusables services transactionExecutor
we are getting the following error -
java.lang.RuntimeException: java.lang.NoSuchMethodError: 'void com.hedera.node.app.service.contract.impl.exec.operations.CustomCallOperation.<init>(com.hedera.node.app.service.contract.impl.exec.FeatureFlags, org.hyperledger.besu.evm.gascalculator.GasCalculator, com.hedera.node.app.service.contract.impl.exec.AddressChecks)'Services
CustomCallOperationclashes with our CustomCallOperation.java causing the issue.Renaming our CustomCallOperation to
HederaCustomCallOperationsimilar to the other custom operations that we have fixes the conflict.This PR modifies
Rename CustomCallOperation to HederaCustomCallOperation
Related issue(s):
Fixes #
Notes for reviewer:
Checklist